Mar 1, 2022
You're still missing the point. A code smell is a symptom in the code of a deeper design issue. Whether or not to return a boolean literal is a specific practice. It's not a symptom of something else. Code smell is not the right term. The problem is that the term is rarely used correctly. An example of code smell is an unusually large class would represent a possible violation of the single responsibility principle.